golang/go

x/build/cmd/relui: shows a misleading prompt that says "immediately run" when scheduling a workflow (i.e., it doesn't run immediately)

Open

#70,148 opened on Oct 31, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (133,883 stars) (19,008 forks)batch import
BuildersFrictionNeedsInvestigationhelp wanted

Description

When creating a workflow to be executed, relui always shows a prompt that asks:

"This will create and immediately run this workflow. Ready to proceed?"

The "immediately run" part is true whenever the schedule type is "immediately run", but not when the workflow is being scheduled to run at a later date, or on a schedule. In those cases, the workflow doesn't run immediately as the prompt says.

This would be good to fix to reduce confusion. The current logic has a good property that the confirmation prompt is always there as soon as the page loads, without any JavaScript execution delay. We should preserve that property when fixing this.

CC @golang/release.

Contributor guide

Tech stack
go
Domain
clideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Locate the confirmation prompt message in the relui source code under x/build/cmd/relui. The string 'immediately run' should be conditionally changed based on the scheduled type. Ensure the prompt still appears without JavaScript delay.
x/build/cmd/relui: shows a misleading prompt that says "immediately run" when scheduling a workflow (i.e., it doesn't run immediately) · golang/go#70148 | Good First Issue