golang/go

x/website/_content/doc: refer that crypto/ecdsa.GenerateKey is no longer deterministic since Go 1.20

Open

#62,255 opened on Aug 24, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
DocumentationNeedsInvestigationSecurityhelp wantedwebsite

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This change (#58637) recently bit me when upgrading Go, and it left me mad looking for bugs in data transmission when the different keys were the problem.

I gained the habit of reading release notes (at least for major upgrades) to avoid issues, but only the change to the constant-time is mentioned. As it changes existing behavior, I believe it should be in the release notes, so that no one suffers the same fate :)

Contributor guide

Research direction
Add a note in the Go 1.20 release notes explaining that crypto/ecdsa.GenerateKey is no longer deterministic.
Tech stack
go
Domain
documentation
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90