golang/go

x/tools/gopls: 'fix all' code action for selected range

Open

#44,814 opened on Mar 5, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Go (19,008 forks)batch import
FeatureRequestToolsgoplshelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This is a feature request. When working on typescript projects, I liked the 'fix all' code actions presented with other trivial code actions.

For example, consider this case:

Screen Shot 2021-03-05 at 11 57 02 AM

These are trivial ones and these quick fixes can be applicable on save if I had configured

        "editor.codeActionsOnSave": {
            "source.fixAll": true
        }

But, would be nice if I could select a region and trigger fix of all errors in the selected region. Or alternatively, like typescript or eslint extensions, present the fixAll (for the entire file) option using code action.

Contributor guide

Research direction
Investigate the existing code action infrastructure in gopls, specifically how 'fix all' is implemented for entire files, and extend it to operate on a selected range. Look at the gopls codebase in golang.org/x/tools/gopls and understand the source.CodeActions handler.
Tech stack
go
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GogoplsLSP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50