golang/go

cmd/compile: don't compile some unexported, inlined functions

Open

#41,117 opened on Aug 28, 2020

View on GitHub
 (5 comments) (2 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsInvestigationToolSpeedcompiler/runtimehelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If a function is:

  • inlined at all call sites
  • not exported
  • not referred to by value (any uses of the function are as a static call)
  • not present in any interface types in its containing package

then we don't need to compile that function.

I suspect that these conditions are frequently met, cheap to check, and reasonably easy to implement.

I thought we had an issue for this, but I don't see one. I don't plan to work on this. I'm filing it in case someone else wants to. :)

Contributor guide

Research direction
Implement a compiler pass that checks each function: if it is inlined at all call sites, unexported, not referenced by value, and not part of any interface, then skip compiling its body. Start by inspecting the SSA or IR representation in the Go compiler.
Tech stack
go
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gocompiler internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30