golang/go

crypto/cipher: optimize safeXORBytes

Open

#35,381 opened on Nov 5, 2019

View on GitHub
 (11 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsInvestigationPerformanceSuggestedhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The discussion at https://github.com/golang/go/issues/31586 includes several techniques for optimizing xor of byte slices, including using encoding/binary (with native endianness) and loop unrolling. It'd be nice to apply them to safeXORBytes, which is used on many non-amd64 platforms. An optimized safeXORBytes might even be fast enough that we could delete fastXORBytes.

Somewhat related: #30553

cc @nhooyr

Contributor guide

Research direction
Review the referenced issue #31586 and the discussion for optimization techniques like using encoding/binary with native endianness and loop unrolling. Then implement the optimized safeXORBytes, possibly making it fast enough to replace fastXORBytes.
Tech stack
go
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gocrypto/cipher
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40