golang/go

x/build/cmd/gopherbot: fix Gerrit reviewer email addresses

Open

#35,078 opened on Oct 22, 2019

View on GitHub
 (2 comments) (2 reactions) (0 assignees)Go (19,008 forks)batch import
BuildersFeatureRequestNeedsInvestigationhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I have three main email addresses (gmail.com, golang.org, google.com), with three corresponding Chrome identities/Google accounts.

So do many others on the Go team. (Or at least two)

And because I've clicked links to Gerrit reviews while signed into each of the three, Gerrit has helpfully signed me in & made an account for me.

Which then means my name shows up in the autocomplete list for "bradfitz" in three ways.

It's distracting when I get reviews to the wrong email account.

This just bit @ianlancetaylor too.

I realized we could just have a mapping table and make gopherbot fix the reviewers if it sees a wrong one added by mistake.

/cc @dmitshur @andybons @bcmills

Contributor guide

Research direction
Examine the gopherbot code in x/build/cmd/gopherbot to find where reviewer email addresses are set, and implement a mapping table to correct common email variations.
Tech stack
go
Domain
build systemdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70