golang/go

x/oauth2/clientcredentials: context values are not passed to oauth2 requests that retrieve tokens

Open

#33,131 opened on Jul 16, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

It does reproduce with the latest version of golang.org/x/oauth2. I guess this is an issue about this subrepository.

What operating system and processor architecture are you using (go env)?

What did you do?

https://play.golang.org/p/iOdgycJZA4f

This example requires facebook credentials, but the bug does reproduce with any credential source.

What did you expect to see?

There are two requests, one for retrieving an oauth2 token, and the other to get the actual URL.

I expected the two requests to see the same context values, which would generate an output like

context value
context value

What did you see instead?

<nil>
context value

The context value is not passed to the first request.

Contributor guide

Research direction
Trace the context propagation in the clientcredentials package, specifically how the context from the client is passed to the token retrieval request. Look at the HTTP client and request creation to ensure context values are included.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60