golang/go

x/net/websocket: add runnable versions of examples mentioned in Server.Handshake documentation

Open

#32,866 opened on Jul 1, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
DocumentationNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://godoc.org/golang.org/x/net/websocket there is missing example for redefining your own check origin callback or even disabling the existing one

Contributor guide

Research direction
Read the existing websocket documentation and examples in the x/net/websocket package. Create a runnable example for the Server.Handshake that demonstrates how to redefine the check origin callback or disable it. Ensure the example compiles and runs correctly.
Tech stack
go
Domain
backenddocumentation
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoWebSocket
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70