golang/go

internal/singleflight: delete, use golang.org/x/sync/singleflight

Open

#31,697 opened on Apr 26, 2019

View on GitHub
 (13 comments) (4 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The singleflight package started life in internal/singleflight and then moved to golang.org/x/sync/singleflight, and the two have had slightly divergent development histories since. It's getting kinda messy. Their APIs have even somewhat diverged.

I just tried to re-unify them and delete internal/singleflight from std, but we can't use mod/vendor packages during bootstrap.

/cc @ianlancetaylor

Contributor guide

Research direction
Examine the differences between internal/singleflight and golang.org/x/sync/singleflight APIs and implementations. Investigate how the Go bootstrap process prevents using external modules during bootstrapping. Propose a plan to consolidate the two packages without breaking bootstrap, possibly by copying the external implementation into internal or using build tags.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Gounderstanding of Go modulesGo bootstrap process
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40