golang/go

x/build/cmd/gerritbot: auto-reviewers are not applied for some GitHub CLs

Open

#29,569 opened on Jan 4, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
BuildersNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When a PR is created by an author that has a Gerrit account, they are added as a reviewer to their own CL. Since the CL has a reviewer, gerritbot then does not apply autoreviewers.

For example: https://go-review.googlesource.com/c/go/+/156297

Maybe the answer is to add them as CC, not as reviewers. I'm not sure why that's the current behavior, but it might be an automatic Gerrit behavior, similarly to how it adds reviewers if it detects them listed manually as Reviewed-By.

/cc @andybons

Contributor guide

Research direction
Examine the gerritbot code in x/build/cmd/gerritbot to understand how authors are added as reviewers. Consider changing the behavior to add authors as CC instead of reviewers to ensure auto reviewers are applied.
Tech stack
go
Domain
devopsci cdtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GerritGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30