golang/go

os: add test for Windows Dedup volumes

Open

#28,547 opened on Nov 2, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (19,008 forks)batch import
BuildersFeatureRequestOS-WindowsTestinghelp wantednew-builder

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In recent CL 143578, I was going to remove some code that I thought did nothing. My change would have made all files on Windows Dedup volumes ( https://docs.microsoft.com/en-us/windows-server/storage/data-deduplication/overview ) look like symlinks.

Luckily @kolyshkin pointed my mistake ( https://github.com/golang/go/issues/22579#issuecomment-428381201 ). I built Windows instance on Gogle Cloud with extra disk attached as D: drive and with Dedup option on, to test my CL.

I wonder, if we can have one of our Windows builders have small extra disk with Dedup on. Then we could write some appropriate tests that run on that builder.

/cc @bradfitz @johnsonj

Alex

Contributor guide

Research direction
Set up a Windows builder with Dedup volumes and write tests to verify os package behavior.
Tech stack
go
Domain
operating systems
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoWindows
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20