golang/go

net/http: add CONNECT bidi example

Open

#28,178 opened on Oct 12, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
DocumentationNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://go-review.googlesource.com/c/go/+/123156 is removing some documentation from http.Transport that says not to use CONNECT requests with Transport because it's adding CONNECT support.

We should also add examples. CL 123156 has a test which is close at least, but could be cleaned up and be made less unit-testy.

Contributor guide

Research direction
Review the test in CL 123156, simplify it into a runnable example, and add it to net/http package documentation.
Tech stack
go
Domain
backend
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70