golang/go

x/review/git-codereview: when working on the Go repo, use its bin/gofmt if present

Open

#26,336 opened on Jul 11, 2018

View on GitHub
 (8 comments) (2 reactions) (0 assignees)Go (19,008 forks)batch import
NeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

gofmt changed in Go 1.11, and git-codereview uses the gofmt from $PATH, so when that's the Go 1.10 version, it complains as git-codereview: gofmt needs to format these files (run 'git gofmt').

It should instead use the gofmt in GOROOT.

Contributor guide

Research direction
Inspect the git codereview source code to see how it locates gofmt, then modify it to prefer the gofmt from GOROOT over the one in PATH.
Tech stack
go
Domain
toolingdevtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65