golang/go

x/build/cmd/gerritbot: does not respect codereview.cfg for fixing commit messages

Open

#25,337 opened on May 10, 2018

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Go (19,008 forks)batch import
BuildersNeedsFixhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://go-review.googlesource.com/112277, which came from PR golang/vgo#4, said "Fixes #24099." The git-codereview tool would have read the vgo repo's codereview.cfg and automatically rewritten that line to say "Fixes golang/go#24099." This helps both authors and reviewers, neither of whom have to think about this anymore. The PR-bot should do the same, because as a reviewer I certainly don't want to lapse back into being in charge of catching this trivial but common mistake. Because the bot did not fix the commit message, the eventual submit did not close the issue.

Contributor guide

Research direction
Examine the gerritbot code at x/build/cmd/gerritbot to identify where commit messages are processed. Determine how codereview.cfg is parsed in the git codereview tool and add similar logic to the bot to automatically fix commit messages containing issue references without the full repository path.
Tech stack
go
Domain
build systemci cd
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGerritcodereview.cfg
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60