golang/go

testing: add -benchsplit to get more data points

Open

#19,128 opened on Feb 16, 2017

View on GitHub
 (21 comments) (1 reaction) (0 assignees)Go (19,008 forks)batch import
FeatureRequestNeedsFixProposalProposal-Acceptedhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

For #18177, we need to make tradeoffs between worst-case latency and average throughput for the functions in question.

It's relatively easy to measure the average throughput today using benchmarks with the testing package.

It would be nice if I could use those same benchmarks to measure the distribution of timings across iterations. That isn't really feasible using (*B).N with caller-side iteration, but it might at least be possible to tap into (*PB).Next to get some idea of the latency between calls for parallel benchmarks.

Contributor guide

Research direction
Examine the current benchmark implementation in the Go testing package, focusing on how `(*PB).Next` handles iteration counts and timing. Explore the feasibility of adding a ` benchsplit` flag that records timing distributions per iteration or per worker. Consider impact on benchmark output format and backward compatibility.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60