golang/go

test: doesn't use GO_GCFLAGS for tests

Open

#18,222 opened on Dec 7, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import
BuildersNeedsFixTestinghelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

GO_GCFLAGS only affects the compiler that is invoked directly by the dist tool (I think). The compiler invoked by test/run.go doesn't have its command line modified by GO_GCFLAGS. So all of the tests in test/ aren't actually testing what we think they are testing on the modified builders like noopt and ssacheck.

Maybe this is unfixable as a some of the tests in test/ provide their own flags to the compiler. But it surprised me that the ssacheck checks weren't actually running on the ssacheck builder in the test directory.

Maybe there's some way to propagate GO_GCFLAGS that makes sense.

See https://go-review.googlesource.com/c/33909/ for a hack I needed to make this work for randomized value order testing.

@bradfitz @cherrymui @dr2chase

Contributor guide

Research direction
Investigate how test/run.go invokes the compiler and determine a way to propagate GO GCFLAGS to the compiler invocations within tests.
Tech stack
go
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65