golang/go

net/http/cookiejar: add way to access all cookies in CookieJar

Open

#17,587 opened on Oct 25, 2016

View on GitHub
 (15 comments) (21 reactions) (0 assignees)Go (19,008 forks)batch import
FeatureRequestSuggestedhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

1.6.3

What operating system and processor architecture are you using (go env)?

darwin / amd64

What did you do?

Tried to access all cookies stored in a http.CookieJar.

What did you expect to see?

A Function for accessing the []*http.Cookie data. The cookiejar struct is missing a way to access all the cookie structs saved in it. You have to know all the matching urls (as url.URL structs) in order to pull cookies out of it.

What did you see instead?

Only a method for reading cookies from pre-known url.URL structs.

Contributor guide

Research direction
Look at the cookiejar source code, particularly the Jar struct and its methods. Design a new exported method to return all cookies stored in the jar. Ensure it respects the jar's internal storage and consider thread safety.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gonet/http
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75