golang/go

x/build/cmd/gopherbot: -2 any CLs with large binary blobs unless declared in commit message

Open

#10,658 opened on May 1, 2015

View on GitHub
 (21 comments) (3 reactions) (0 assignees)Go (19,008 forks)batch import
BuildersFeatureRequestNeedsInvestigationhelp wanted

Repository metrics

Stars
 (133,883 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

See CL 9560 for context.

There will be cases in which it is legit to add a binary file. In such cases, we could do a force commit. Other suggestions welcomed.

Edit by @dmitshur: This also happened in CL 149604, see #28899.

Contributor guide

Research direction
Examine the gopherbot code in x/build/cmd/gopherbot, understand how it processes CLs, and implement checks for large binary blobs. Refer to CL 9560 and CL 149604 for examples of large binary blobs.
Tech stack
go
Domain
devopsbuild system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60