godaddy/kubernetes-client

Browser compatibility: make swagger-client not dependent on fs

Open

#337 opened on Oct 18, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (954 stars) (206 forks)batch import
help wanted

Description

fs is currently called in the swagger client constructor: https://github.com/godaddy/kubernetes-client/blob/master/lib/swagger-client.js#L106

This causes errors in browser and makes it very difficult to construct a browser-friendly swagger client.

Contributor guide

Tech stack
javascriptnodejs
Domain
full stack
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js fsBrowser compatibilityJavaScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate lib/swagger client.js to find all references to the 'fs' module. Replace them with browser compatible equivalents, such as using the 'fetch' API for HTTP requests and other client side storage mechanisms. Review the comments on the issue for any suggested approaches. Ensure that the changes do not break existing Node.js functionality by providing conditional checks for the environment.
Browser compatibility: make swagger-client not dependent on fs · godaddy/kubernetes-client#337 | Good First Issue