godaddy/kubernetes-client

Browser compatibility: make swagger-client not dependent on fs

Open

#337 opened on Oct 18, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (206 forks)batch import
help wanted

Repository metrics

Stars
 (954 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

fs is currently called in the swagger client constructor: https://github.com/godaddy/kubernetes-client/blob/master/lib/swagger-client.js#L106

This causes errors in browser and makes it very difficult to construct a browser-friendly swagger client.

Contributor guide

Research direction
Investigate alternative approaches to reading files without fs, such as using fetch for remote URLs or inlining swagger specs. Consider using bundler friendly imports for Node.js vs browser.
Tech stack
javascriptnodejs
Domain
backendfrontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70