godaddy/kubernetes-client

Delete deployment and associated pods?

Open

#148 opened on Sep 28, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (954 stars) (206 forks)batch import
help wantedrequest for example

Description

Hi,

const Api = require('kubernetes-client');

const deploy = new Api.Extensions({
    url: 'https://SERVER:6443',
    version: 'v1beta1',  // Defaults to 'v1beta1'
    insecureSkipTlsVerify: true,
    auth: {
        user: 'root',
        pass: 'pass'
    }
});

function print(err, result) {
    console.log(JSON.stringify(err || result, null, 2));
}

// deploy.ns('fortesting').deploy('echoserver').get(print);
deploy.ns('fortesting').deploy({name: 'echoserver', qs: { PropagationPolicy: false }}).delete(print);

Output:

{
  "code": 404
}

I can delete the deploy with 'deploy.ns('fortesting').deploy('echoserver').delete(print);` but this command cannot delete the pods, which I've created through deploy.

I've found the issue #62 , the option orphanDependents is depricated ([https://kubernetes.io/docs/api-reference/v1.6/#deployment-v1beta1-extensions](doc api)) it's now PropagationPolicy.

Contributor guide

Tech stack
javascriptnodejs
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js basicsKubernetes deployment conceptsREST API usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the delete method in the Kubernetes client library to understand how query parameters like PropagationPolicy are handled. The issue mentions that the option 'orphanDependents' is deprecated and replaced by 'PropagationPolicy', but the client may not support the new field. Check the relevant source file (likely lib/extensions.js or similar) and the Kubernetes API documentation for v1beta1 extensions to implement proper support. Also review linked issue #62 for context.