godaddy/kubernetes-client

Get pods via LabelSelctor

Open

#144 opened on Aug 31, 2017

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (954 stars) (206 forks)batch import
help wantedrequest for example

Description

When trying to get pods via label selector I get all pods returned in the name space. core.ns.po.get({ qs: { labelSelector: 'mylabel=thelabel' } }, (err, results) = > { console.log(results); });

Not sure what the correct method would be for getting pods based on label selectors. Looking through the code base, I noticed the .get on pods will not accept the label selector. https://github.com/godaddy/kubernetes-client/blob/master/lib/replicationcontrollers.js#L46

Am I overlooking something simple?

Contributor guide

Tech stack
javascriptnodejsrest api
Domain
apibackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js basicsKubernetes conceptsREST API basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the current state of the kubernetes client library, focusing on the pods endpoint. The issue reports that the get method on pods does not handle the labelSelector query parameter. Look at lib/replicationcontrollers.js as referenced, and the main API code for pods. Determine if this bug is still present in the latest version and if not, what the correct usage is. If it remains, implement support for labelSelector by adding it to the query string options.