gocolly/colly

[Feature Request] InMemoryStorage supports TTL for visited URLs

Open

#136 opened on May 9, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Go (1,837 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (24,898 stars)
PR merge metrics
 (Avg merge 15h 38m) (2 merged PRs in 30d)

Description

type InMemoryStorage struct {
  // TTL
  visitedURLsTTL time.Duration
}

I think handling TTL for visited URLs internally is quite useful, and we can make redisstorage to support TTL as well. @asciimoo WDYT

Contributor guide

Research direction
Explore the InMemoryStorage struct and its methods in the colly source code. Add a TTL field and modify the visited URL check logic to expire entries after TTL. Also consider RedisStorage for similar support.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70