gocolly/colly

[Feature Request] InMemoryStorage supports TTL for visited URLs

Open

#136 opened on May 9, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Go (24,898 stars) (1,837 forks)batch import
enhancementhelp wanted

Description

type InMemoryStorage struct {
  // TTL
  visitedURLsTTL time.Duration
}

I think handling TTL for visited URLs internally is quite useful, and we can make redisstorage to support TTL as well. @asciimoo WDYT

Contributor guide

Tech stack
goredis
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingcolly framework basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the storage package in the colly repository, particularly the InMemoryStorage implementation. Understand how visited URLs are stored and checked. Implement a TTL duration field and add expiration logic, possibly using a background goroutine. Also consider making redisstorage support TTL if applicable.