go-sql-driver/mysql

NullTime does not use DSN location

Open

#568 opened on Apr 14, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (9,946 stars) (1,789 forks)batch import
help wanted

Description

Issue description

The NullTime helper is hardcoded to parse in location time.UTC but should really use the location set in the DSN (which defaults to UTC). Maybe you could have a variable in the utils timeZone that gets set during DSN Parsing?

Contributor guide

Tech stack
go
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go basicsdatabase/sql packageMySQL driver DSN parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the DSN parsing logic in the MySQL driver to see how location is handled (likely in a function like `parseDSN`). Then examine the NullTime implementation in `utils.go` to understand why it currently hardcodes UTC. The fix involves using a stored location variable instead of UTC, ensuring it is set during DSN parsing. Check existing comments or related issues for any prior discussion.