go-sql-driver/mysql

NullTime does not use DSN location

Open

#568 opened on Apr 14, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (1,789 forks)batch import
help wanted

Repository metrics

Stars
 (9,946 stars)
PR merge metrics
 (Avg merge 5h 59m) (4 merged PRs in 30d)

Description

Issue description

The NullTime helper is hardcoded to parse in location time.UTC but should really use the location set in the DSN (which defaults to UTC). Maybe you could have a variable in the utils timeZone that gets set during DSN Parsing?

Contributor guide

Research direction
Investigate the NullTime parsing code and the DSN parsing to enable configurable timezone instead of hardcoded UTC.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70