go-shiori/shiori

Table bookmark_content_data is not cleared on "shiori delete"

Open

#547 opened on Jan 1, 2023

View on GitHub
 (2 comments) (0 reactions) (1 assignee)JavaScript (561 forks)batch import
component:backenddatabasegood first issuetype:bug

Repository metrics

Stars
 (8,271 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Data

  • Shiori version: 1.5.3
  • Database Engine: SQLite
  • Operating system: from Dockerfile
  • CLI/Web interface/Web Extension: N/A

Describe the bug / actual behavior

Deleting all bookmarks with shiori delete doesn't clear the table bookmark_content_data.

Expected behavior

All bookmark related data is deleted on shiori delete including table bookmark_content_data

To Reproduce

Steps to reproduce the behavior:

  1. "shiori delete -y"
  2. Check table bookmark_content_data. For example with https://sqlitebrowser.org/

image

image

Contributor guide

Research direction
Locate the delete handler in the backend, identify where bookmark deletion occurs, and add a query to remove rows from bookmark content data.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80