go-kit/kit

support for istio distributed tracing

Open

#977 opened on Apr 26, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (27,422 stars) (2,446 forks)batch import
enhancementhelp wanted

Description

Hi guys,

I've been using go-kit for some times now (high five for the amazing work !) and have been developing micro-services on Kubernetes and istio where istio tracing is leveraged. If interested in supporting istio tracing through simple header propagation (istio doc), I have working code that I would be happy to push through a pull request.

Basically the code implements the function func ServerBefore(before ...RequestFunc) ServerOption for HTTP and gRPC

defined here

so that header values can be saved in the context, and then inject to every downstream requests.

Is it something you see being pushed to your code base ? Let me know. Cheers

Contributor guide

Tech stack
go
Domain
observabilitybackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Gogo kit basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue proposes adding Istio distributed tracing support via header propagation. The author has working code but asks for maintainer interest. The relevant files are transport/http/server.go and transport/grpc/server.go. To contribute, review the existing code, integrate the header propagation logic, and add tests. Ensure compatibility with the existing context based middleware patterns in go kit.