go-kit/kit

Using prometheus collector MustRegister in New{Counter,Gauge} and possible panic

Open

#937 opened on Nov 14, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Go (2,446 forks)batch import
bughelp wantednewbie friendly

Repository metrics

Stars
 (27,422 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Thanks for the wonderful product! I think it would be fair to point the limitations of calling New in the documentation, since calling New again calls panic.

Contributor guide

Research direction
Review the documentation for NewCounter and NewGauge functions and add a note about the risk of panic when calling MustRegister twice.
Tech stack
go
Domain
backend
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80