go-kit/kit

Feature request: grpc conn manager

Open

#862 opened on Apr 15, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (27,422 stars) (2,446 forks)batch import
enhancementhelp wanted

Description

Ref: https://github.com/go-kit/kit/blob/master/examples/apigateway/main.go#L184

Based on this hint, I wrote some code and wondered if this could be contributed to the kit. Do you have time to look at it @ChrisHines ? If it is not good enough, can it be an example? Here, https://github.com/MaruHyl/xgrpc

Contributor guide

Tech stack
gogrpc
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
gRPCGogo kit basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Review the provided link to go kit's example apigateway and the user's xgrpc repository. Investigate how the proposed gRPC connection manager would fit into go kit's transport package. Look for any existing discussions or open PRs related to gRPC support.