go-kit/kit

SD - Registrator error handling

Open

#780 opened on Oct 23, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (2,446 forks)batch import
enhancementhelp wantednewbie friendly

Repository metrics

Stars
 (27,422 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is there any reason for not returning any error on the registration of a service? https://github.com/go-kit/kit/blob/ec0cc13a9b00d1214c9b7ae63d7b750626b54c6d/sd/registrar.go#L11

From my point of view, if a service doesn't manage to correctly register, then it might be nice to retry later. Binding to events to watch if you're correctly registered seems overkilled compared to just checking this error.

What are your thoughts?

Contributor guide

Research direction
Examine the existing registration function in sd/registrar.go and determine where to add error return, then update the interface and callers accordingly.
Tech stack
go
Domain
backendinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60