go-kit/kit

Please, add proper attribution to log/term/*

Open

#640 opened on Dec 11, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (27,422 stars) (2,446 forks)batch import
enhancementhelp wanted

Description

Hi,

While preparing a Debian package for go-kit, the FTP masters rejected my package because of missing attribution in log/term/*

I checked the code and it seems it is deriving from ssh/terminal (although I don't see much code coming from there) and from github.com/mattn/go-colorable. There is a LICENSE file, which does not attribute properly either work, nor their original licenses (the Go license is BSD, not MIT), and attributes code to one Simon Eskildsen, who's not mentioned anywhere else.

All in all, copyright and licensing is very unclear in that directory. Could you please clarify it?

Thanks!

Contributor guide

Tech stack
go
Domain
documentation
Issue type
documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic understanding of open source licensing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the files in log/term/ and the existing LICENSE file. Identify the original sources (ssh/terminal from Go's standard library and github.com/mattn/go colorable) and their licenses. Add proper attribution to the LICENSE file, including the BSD license for the Go code and the MIT license for go colorable, ensuring compliance with their terms. Also, clarify the mention of Simon Eskildsen if necessary.