go-delve/delve

pkg/proc/native: intermittent test failures in TestWatchpointsBasic

Open

#2768 opened on Oct 29, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (24,010 stars) (2,177 forks)batch import
area/proc/nativehelp wantedkind/bugos/windows

Description

Example: https://delve.teamcity.com/viewLog.html?buildId=27817

For whatever reason it seems that the hardware breakpoint state gets restored somehow on some threads, sometimes, after a hardware breakpoint has been disabled.

Contributor guide

Tech stack
go
Domain
backendtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of hardware breakpointsGo programmingFamiliarity with delve internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
The issue describes intermittent test failures in the TestWatchpointsBasic test, likely related to hardware breakpoint state restoration. Investigate the test file pkg/proc/native/proc test.go and related hardware breakpoint handling code in pkg/proc/native/. Reproduce the failure using the provided TeamCity build log. Check if there are any known races or missing synchronizations when disabling hardware breakpoints on threads.