go-chi/chi

Refactor throttle middleware tests as prone to intermittent failure

Open

#608 opened on Mar 25, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (8,127 stars) (555 forks)batch import
help wanted

Description

https://github.com/go-chi/chi/blob/master/middleware/throttle_test.go

It's often that when I submit a PR, and the code runs through github ci, it will fail -- https://github.com/go-chi/chi/actions

I have to re-run the jobs to have it pass, it seems to be a timing issue. When running locally, it seems to work well pretty consistently, but I've seen the rare failing case.

Contributor guide

Tech stack
go
Domain
backendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingunderstanding of middleware
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the throttle middleware test file at middlewware/throttle test.go to identify timing dependent assertions. Consider implementing a deterministic test approach, such as using a mock clock or channel based synchronization, to eliminate intermittent failures. Review existing comments and linked CI failures for patterns.