glue-viz/glue-openspace

Avoid removing and adding graph node when updating properties

Open

#1 opened on Jun 26, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (4 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (2 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

At the moment, whenever any aspect of a layer is changed, we remove the graph node from OpenSpace and add a new one (this is done in layer_artist.py). We should make sure that we only add the graph node once and then make updates by setting only the properties that need to be set. This can include:

  • Changing the data to be shown (e.g. if a subset changes, or the attributes for the RA/Dec change)
  • Color
  • Visibility
  • Transparency
  • Point size/brightness

Contributor guide

Research direction
Inspect the current implementation in layer artist.py to understand how graph nodes are removed and added. Then identify which properties (data, color, visibility, transparency, point size/brightness) are being updated unnecessarily and modify the code to only set specific properties on the existing node instead of recreating it.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70