glortho/react-keydown

componentWillReceiveProps will be deprecated

Open

#87 opened on Sep 24, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (505 stars) (40 forks)batch import
help wanted

Description

According to React, using componentWillReceiveProps() is a bad idea and it will be deprecated soon, version 17 seems to be the last supporting the method with that name.

When using keydown for classes, what should be the proper way to handle the key events?

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactClass components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
First, review the React documentation on the deprecation of componentWillReceiveProps and the recommended alternatives (getDerivedStateFromProps or componentDidUpdate). Then, search the codebase for all uses of componentWillReceiveProps, particularly in the keydown handling logic. Consider whether the component can be converted to a functional component with hooks, or if class components must be retained. The issue comments may provide additional context. Finally, implement the replacement and ensure keydown events still work correctly.
componentWillReceiveProps will be deprecated · glortho/react-keydown#87 | Good First Issue