globalizejs/globalize

Relative Time: Accept numberFormatter as optional argument

Open

#531 opened on Oct 10, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import
help wantedquick changerelative time module

Description

It should be possible to:

var relativeTimeFormatter = Globalize( "en" ).relativeTimeFormatter(  "month", {
  numberFormatter: myFormatter
});

Contributor guide

Tech stack
javascript
Domain
localizationinternationalization
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of Globalize libraryfamiliarity with number formatting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests adding an optional `numberFormatter` argument to `relativeTimeFormatter`. To implement, examine the `src/relative time.js` file where the current formatter is defined. Look at how other formatters (e.g., `numberFormatter`) accept options. The change involves modifying the function signature and applying the custom formatter if provided. No linked PRs or comments provide additional context.