globalizejs/globalize

Date: Handle undefined skeleton

Open

#469 opened on Jul 23, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (645 forks)batch import
date modulehelp wantedquick change

Repository metrics

Stars
 (4,759 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When using an undefined skeleton, e.g., {skeleton: '<anything here that doesn't exist>'} https://github.com/jquery/globalize/blob/master/src/date.js#L64 returns undefined, which in turn is passed as the expanded-pattern to the formatter, which in turn tries to recognize u and fails.

Originally raised on #455.

Contributor guide

Research direction
Find the source file src/date.js line 64, understand the skeleton handling logic, and add a guard clause for undefined skeleton.
Tech stack
javascript
Domain
full stack
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80