globalizejs/globalize

Date: Handle undefined skeleton

Open

#469 opened on Jul 23, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import
date modulehelp wantedquick change

Description

When using an undefined skeleton, e.g., {skeleton: '<anything here that doesn't exist>'} https://github.com/jquery/globalize/blob/master/src/date.js#L64 returns undefined, which in turn is passed as the expanded-pattern to the formatter, which in turn tries to recognize u and fails.

Originally raised on #455.

Contributor guide

Tech stack
javascript
Domain
localizationinternationalization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with JavaScriptunderstanding of date formatting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is in the Date module of the Globalize library. The bug occurs at src/date.js line 64 when an undefined skeleton is passed. The value `undefined` is passed to the formatter, causing a failure. A fix would involve adding a check for undefined before using the skeleton. Refer to the original issue #455 for more context. The repository is a JavaScript project for internationalization using CLDR data.