globalizejs/globalize

Performance tests

Open

#397 opened on Feb 17, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import
help wantednew feature

Description

Goal

Test the performance impact of fixes/changes. So, we ensure our performance is continuously improved; In other words, we're interested in comparing how fixes or changes affect the systemic performance of the library.

General Ideas

  • We need to compare the performance before and after a change. Therefore, we need a metric describing how fast Globalize performs what it's supposed to.
  • We're interested in the systemic performance of the library. Therefore, performance tests performance/* should use the built files dist/* (and public methods Globalize.*), analogous to the functional tests test/functional/*.
  • Keep it simple. The performance tests are about generating the performance metrics (benchmark). A second and different problem is about comparing two different results. For this one, consider something analogous to https://github.com/rwaldron/grunt-compare-size.

Workload

  • We need to define that. It should reflect what Globalize applications look like.
  • Vyacheslav Egorov talks about shitty workloads you should avoid.

References

Contributor guide

Tech stack
javascript
Domain
performancetesting
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
JavaScriptbenchmarking conceptsGlobalize API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate existing performance test patterns in other libraries like jQuery Sizzle. Define realistic workloads that reflect typical Globalize usage (e.g., date formatting, number parsing). Consider using benchmark.js for microbenchmarks and a comparison tool like grunt compare size for regression detection. Start by setting up a basic benchmark structure in the performance/ directory, and document the methodology for future contributors.