globalizejs/globalize

Test: Consider using Sinon.js instead of FakeDate

Open

#382 opened on Jan 12, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import
help wanted

Description

Ref: https://github.com/jquery/globalize/pull/374

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of testingFamiliarity with Sinon.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the referenced pull request (#374) to understand the motivation and proposed changes. Investigate the current usage of FakeDate in the test suite and replace it with Sinon.js equivalents, following the patterns established in the PR.