globalizejs/globalize

Date: Handle `{_value, _number}` entries

Open

#378 opened on Jan 8, 2015

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import
date modulehelp wantednew featurequick change

Description

Globalize("haw").formatDate(new Date(), {datetime: "short"}) throws Error: E_UNSUPPORTED: Unsupported {"feature":"timezone patternv"}. But, what happens is that /main/haw/.../dateFormats/short is actually an object instead of a string (expected).

              "short": {
                "_value": "d/M/yy",
                "_numbers": "M=romanlow"
              }

haw and haw-US seems to be the only locales affected.

  1. Find such case in the UTS#35 specification.
  2. Fix implementation.

Contributor guide

Tech stack
javascript
Domain
localization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptCLDR data formatGlobalize library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the CLDR data for the 'haw' locale to understand how ` value` and ` numbers` keys are used in date patterns. Look for similar patterns in other locales. Then update the date formatting code in Globalize to handle object valued patterns instead of expecting a string. Relevant files likely include src/date.js or similar. Check the UTS#35 specification for the correct interpretation.