globalizejs/globalize

Tests: Dependencies

Open

#372 opened on Dec 19, 2014

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import
help wanted

Description

On https://github.com/jquery/globalize/pull/370, we had missing dependencies. But, we were unable to figure that out by our current unit tests. They are indirect dependencies (i.e., "plugin dependencies") and another parallel unit test was loading them before they were being used. Therefore, no problem occurred until we started to test them on high latency envs like via browserstack-runner.

Ideally, each unit test should be executed using the dependencies it's explicitly requiring with no interference.

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptunit testingglobalize library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the linked PR #370 to understand the missing dependencies issue. Examine the current test setup in globalize to identify where each test file loads its dependencies. Look for patterns where parallel tests inadvertently load dependencies for others, and design a per test dependency injection approach. The goal is to ensure each unit test explicitly requires its own dependencies without interference from other tests.