globalizejs/globalize

Build: check built files don't contain external dependencies

Open

#371 opened on Dec 19, 2014

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import
help wanted

Description

We just dealt with failures in functional tests that turned out to be caused by cldr/supplemental being added as a dependecy in one place, but not properly included in the build in a different place (requirejs build configuration, exclude option).

To make it easier to spot this kind of issue, we should write a build task that looks at files built in dist/ and throws an error if any file contains the Cldrjs library, or any other always-excluded dependency.

Contributor guide

Tech stack
javascript
Domain
build systemdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptRequireJSNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the existing build configuration (likely a Gruntfile or similar) to understand the current build process. The task should parse files in the dist/ directory and throw an error if any file contains a regex pattern matching 'cldrjs' or other excluded dependencies. Consider adding a new Grunt task or npm script.