globalizejs/globalize

Code cleanup: Can we remove the nested functions pattern of util.assertFns?

Open

#361 opened on Dec 8, 2014

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import
help wantedquick change

Description

Ref: https://github.com/jquery/globalize/pull/351/files#r21450932

util.assertCurrencyParameter( assert, "currency", function( invalidValue ) {
 return function() {
    Globalize.currencyFormatter( invalidValue );
  };
});

@jzaefferer

I guess we've discussed this before as well, still doesn't make much sense: Why does this test have to return two nested functions?

@rxaviers

Yeap, we have discussed about this and it was clear this was needed. Although, I also believe this could be simplified.

Contributor guide

Tech stack
javascript
Domain
localizationtesting
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptUnderstanding of Globalize test utilities
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Review the linked pull request #351 to understand the current nested function pattern. Then, search the codebase for uses of util.assertFns and similar patterns. Propose a refactored version that removes the nested functions while preserving functionality. Check for any existing tests that depend on the current shape.