globalizejs/globalize

Code cleanup: Decouple validation from execution tests

Open

#360 opened on Dec 8, 2014

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (645 forks)batch import
help wantedquick change

Repository metrics

Stars
 (4,759 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Ref: https://github.com/jquery/globalize/pull/351/files#r21451357

It's about decoupling the tests that need an extraStep() to load extra CLDR vs. the ones that tests validations and requires that data not to be loaded.

Contributor guide

Research direction
Examine the test files to identify which tests require the extraStep() to load CLDR data and which tests validate behavior without that data. Then separate them into different test suites or conditionally run them based on the presence of the extra CLDR data.
Tech stack
javascript
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75