globalizejs/globalize

Code cleanup: Decouple validation from execution tests

Open

#360 opened on Dec 8, 2014

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import
help wantedquick change

Description

Ref: https://github.com/jquery/globalize/pull/351/files#r21451357

It's about decoupling the tests that need an extraStep() to load extra CLDR vs. the ones that tests validations and requires that data not to be loaded.

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScripttest driven development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the linked PR #351 to understand the current test structure. Identify tests that use extraStep() and those that test validations without extra data. Then separate these test files or test cases accordingly.