globalizejs/globalize

Code cleanup: Simplify tests util functions that passes assert as a parameter

Open

#359 opened on Dec 8, 2014

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (645 forks)batch import
help wantedquick change

Repository metrics

Stars
 (4,759 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Ref: https://github.com/jquery/globalize/pull/351/files#r21450909

util.assertParameterPresence( assert, "currency", function() {
  Globalize.currencyFormatter();
});

@jzaefferer

I brought this up before, might be worth another try. Can this be changed to the below?

assert.parameterPresence( "currency", ... );

The same applies to any other calls that pass assert as a parameter

@rxaviers

Sorry if I missed it. But, I don't remember such comment. If you say it's better overloading assert, it shall be. Will be tracked as a separate issue #359

Contributor guide

Research direction
Examine the test utility functions in the repository, particularly those that accept 'assert' as a parameter. Refactor them to attach the utility functions directly to the assert object to simplify calls. Follow the pattern suggested in the issue comments.
Tech stack
javascript
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65