globalizejs/globalize

Code cleanup: Simplify tests util functions that passes assert as a parameter

Open

#359 opened on Dec 8, 2014

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import
help wantedquick change

Description

Ref: https://github.com/jquery/globalize/pull/351/files#r21450909

util.assertParameterPresence( assert, "currency", function() {
  Globalize.currencyFormatter();
});

@jzaefferer

I brought this up before, might be worth another try. Can this be changed to the below?

assert.parameterPresence( "currency", ... );

The same applies to any other calls that pass assert as a parameter

@rxaviers

Sorry if I missed it. But, I don't remember such comment. If you say it's better overloading assert, it shall be. Will be tracked as a separate issue #359

Contributor guide

Tech stack
javascript
Domain
testingdeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of JavaScript testing practices
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue proposes refactoring test utility calls throughout the test suite to avoid passing the assert object as a parameter. Instead, the assert methods should be called directly on the assert object. The refactoring pattern is shown in the issue: change from `util.assertParameterPresence(assert, ...)` to `assert.parameterPresence(...)`. This change needs to be applied to all similar calls in the test files. Since the issue is old and no linked PRs exist, the contributor should search the repository's test files (likely under the 'test' directory) for occurrences of functions that take 'assert' as a first parameter and update them accordingly. The maintainer's comment suggests this is a mechanical change that improves code readability.