glideapps/quicktype

Incorrect filename in comment in TS output

Open

#971 opened on Jul 22, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (968 forks)batch import
TypeScriptgood first issue

Repository metrics

Stars
 (10,867 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Running quicktype from the command line like so

quicktype --src-lang schema -o src/cli/ExperimentCounts.ts src/counts.schema

yields

// To parse this data:
//
//   import { Convert, ExperimentCounts } from "./file";

Contributor guide

Research direction
Find the template or function that generates the comment and change the hardcoded './file' to use the actual output filename.
Tech stack
typescript
Domain
clitooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75