glideapps/quicktype

Closing quicktype's stdout makes it output an error in some cases

Open

#864 opened on May 21, 2018

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (10,867 stars) (968 forks)batch import
CLIgood first issue

Description

Marks-iMac:quicktype schani$ ./script/quickesttype --src-lang schema --lang swift --just-types ./test/inputs/schema/vega-lite.schema   | head -n 4
import Foundation

struct VegaLite {
    /// URL to [JSON schema](http://json-schema.org/) for a Vega-Lite specification. Unless you

Issue in line 1390: quicktype cannot infer this type because there is no data about it in the input.
1390:     let on: Any?

Issue in line 1537: quicktype cannot infer this type because there is no data about it in the input.
1537:     let on: Any?

Issue in line 1585: quicktype cannot infer this type because there is no data about it in the input.
1585:     let on: Any?

Issue in line 4583: quicktype cannot infer this type because there is no data about it in the input.
4583:     let on: Any?
events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at exports._errnoException (util.js:1024:11)
    at WriteWrap.afterWrite [as oncomplete] (net.js:851:14)
Marks-iMac:quicktype schani$ ./script/quickesttype --lang swift --just-types ./test/inputs/json/samples/pokedex.json   | head -n 4
import Foundation

struct Pokedex {
    let pokemon: [Pokemon]
Marks-iMac:quicktype schani$ ./script/quickesttype --quiet --src-lang schema --lang swift --just-types ./test/inputs/schema/vega-lite.schema   | head -n 4
import Foundation

struct VegaLite {
    /// URL to [JSON schema](http://json-schema.org/) for a Vega-Lite specification. Unless you
events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at exports._errnoException (util.js:1024:11)
    at WriteWrap.afterWrite [as oncomplete] (net.js:851:14)

Contributor guide

Tech stack
typescriptnodejs
Domain
clibackenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js streamsquicktype codebase familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue occurs when stdout is closed early (e.g., piping to 'head'), causing an unhandled EPIPE error. The fix involves adding an error handler on process.stdout to ignore the EPIPE error. Locate where quicktype writes output, likely in the CLI entry point or output stream module, and attach a listener for 'error' event on process.stdout. Consider using process.stdout.on('error', () => {}) to suppress the error without crashing.