glideapps/quicktype

Superfluous C# using statements

Open

#800 opened on Apr 15, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (10,867 stars) (968 forks)batch import
C#good first issue

Description

The using statements introduced for DateTimeOffset support (if I recall correctly) are emitted in attributes-only mode, and when there are no dates in the model:

using System.Globalization;
using Newtonsoft.Json.Converters;

Contributor guide

Tech stack
typescriptcsharp
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# syntaxquicktype codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the C# code generation logic in quicktype, likely in src/language/csharp.ts or similar. Look for where using statements are emitted, particularly for DateTimeOffset and Newtonsoft.Json. Ensure they are only emitted when needed (e.g., when dates are present or not in attributes only mode).