glideapps/quicktype

Superfluous C# using statements

Open

#800 opened on Apr 15, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (968 forks)batch import
C#good first issue

Repository metrics

Stars
 (10,867 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The using statements introduced for DateTimeOffset support (if I recall correctly) are emitted in attributes-only mode, and when there are no dates in the model:

using System.Globalization;
using Newtonsoft.Json.Converters;

Contributor guide

Research direction
Find the template or code that emits using statements for DateTimeOffset and add a condition to only include them when the model contains date fields.
Tech stack
typescriptcsharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80