glideapps/quicktype

Split up tests with huge objects

Open

#559 opened on Feb 17, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (10,867 stars) (968 forks)batch import
CIgood first issue

Description

We have a few tests, in particular blns-object, keywords.json, and keyword-unions.schema, which have huge objects and slow down a few languages, particularly Rust. The objects don't need to be big - they're only testing that the keys in the objects work, so we can easily split them up without losing the benefit of the tests.

Contributor guide

Tech stack
typescript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with quicktype's test structureUnderstanding of JSON Schema test files
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue identifies three test files: blns object, keywords.json, and keyword unions.schema. The goal is to split the large objects in these files into smaller, focused tests. Review the current test structure in the repository, particularly how tests are organized and run. Then create separate test cases for each key or group of keys, ensuring the same coverage is maintained without the large objects. No linked PRs or comments are available for guidance.
Split up tests with huge objects · glideapps/quicktype#559 | Good First Issue