glideapps/quicktype

Split up tests with huge objects

Open

#559 opened on Feb 17, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (968 forks)batch import
CIgood first issue

Repository metrics

Stars
 (10,867 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We have a few tests, in particular blns-object, keywords.json, and keyword-unions.schema, which have huge objects and slow down a few languages, particularly Rust. The objects don't need to be big - they're only testing that the keys in the objects work, so we can easily split them up without losing the benefit of the tests.

Contributor guide

Research direction
Locate the test files `blns object`, `keywords.json`, and `keyword unions.schema` in the repository. Analyze the large objects and split them into smaller, focused tests that test individual keys or groups of keys. Ensure the test logic remains unchanged and that the new tests cover the same scenarios.
Tech stack
typescriptrust
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gittest framework knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70