glideapps/quicktype

Kotlin date and datetime types are generated as strings from json schema

Open

#2460 opened on Jan 3, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (10,867 stars) (968 forks)batch import
Kotlinbuggood first issueinput:JSON Schema

Description

Kotlin generated data classes use string instead of date or datetime Here is the part of the schema: "properties": { "PlannedDateTime" : { "type" : "string", "format" : "date-time", "examples" : [ "2020-02-03T08:00:00.000+01:00" ], "description" : "When the planing process is finished, this timestamp is set and never changed afterwards (frozen value). It is expressed as a local time plus timezone offset, so UTC can be derived by a simple calculation." }, "pokemon": { "type": "array", "description": "All pokémon contained in the pokédex", "items": { "$ref": "#/definitions/Pokemon" }

    }
  },

Generated result is:

data class PokedexSchema ( /** * When the planing process is finished, this timestamp is set and never changed afterwards * (frozen value). It is expressed as a local time plus timezone offset, so UTC can be * derived by a simple calculation. */ val plannedDateTime: String,

/**
 * All pokémon contained in the pokédex
 */
val pokemon: List<Pokemon>

)

Contributor guide

Tech stack
typescriptkotlin
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Kotlinunderstanding of JSON schema formatsbasic knowledge of quicktype's code structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the Kotlin code generation logic in quicktype, likely in src/language/Kotlin.ts or similar files. Look for how other languages (e.g., Swift, TypeScript) handle date time formats and replicate that pattern for Kotlin. The issue is that format 'date time' should map to a Kotlin datetime type (e.g., LocalDateTime or Instant) instead of String. Check if there are existing date time type mappings in the codebase and ensure they are used correctly.