glideapps/quicktype

Swift 5.9 warning about Hashable being deprecated

Open

#2423 opened on Oct 11, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (10,867 stars) (968 forks)batch import
Swiftgood first issue

Description

Generate swift code has compilation warning about deprecated protocol.

SamSchema.swift:5645:16: warning: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'JSONNull' to 'Hashable' by implementing 'hash(into:)' instead
    public var hashValue: Int {

Using :

swift --version 
swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-5.9.0.128.108 clang-1500.0.40.1)
Target: arm64-apple-macosx14.0

Steps to reproduce :

curl -o sam.schema.json https://raw.githubusercontent.com/aws/serverless-application-model/develop/schema_source/sam.schema.json

quicktype -s schema sam.schema.json -o SamSchema.swift

swift SamSchema.swift 
SamSchema.swift:5645:16: warning: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'JSONNull' to 'Hashable' by implementing 'hash(into:)' instead
    public var hashValue: Int {

Expected behaviour : generated code is updated to not include deprecated features.

Thanks !

Contributor guide

Tech stack
swifttypescript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Swift knowledgeFamiliarity with quicktype's codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is about updating Swift code generation to replace deprecated 'Hashable.hashValue' with 'hash(into:)'. Look at quicktype's Swift code generation templates, likely in src/language/Swift. Find where JSONNull conforms to Hashable and implement the hash(into:) method. Test by generating Swift code from the SAM schema and verifying no warnings.