glideapps/quicktype

Swift 5.9 warning about Hashable being deprecated

Open

#2,423 opened on Oct 11, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (968 forks)batch import
Swiftgood first issue

Repository metrics

Stars
 (10,867 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Generate swift code has compilation warning about deprecated protocol.

SamSchema.swift:5645:16: warning: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'JSONNull' to 'Hashable' by implementing 'hash(into:)' instead
    public var hashValue: Int {

Using :

swift --version 
swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-5.9.0.128.108 clang-1500.0.40.1)
Target: arm64-apple-macosx14.0

Steps to reproduce :

curl -o sam.schema.json https://raw.githubusercontent.com/aws/serverless-application-model/develop/schema_source/sam.schema.json

quicktype -s schema sam.schema.json -o SamSchema.swift

swift SamSchema.swift 
SamSchema.swift:5645:16: warning: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'JSONNull' to 'Hashable' by implementing 'hash(into:)' instead
    public var hashValue: Int {

Expected behaviour : generated code is updated to not include deprecated features.

Thanks !

Contributor guide

Research direction
Locate the Swift template that defines the JSONNull class's hashValue property and replace it with the hash(into:) method. Ensure the generated Swift code is compatible with Swift 5.9.
Tech stack
typescriptswift
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75