glideapps/quicktype

Please generate "final" Swift classes

Open

#1241 opened on May 30, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (10,867 stars) (968 forks)batch import
Swiftcustomizationgood first issue

Description

All of the generated Swift classes should be "final class" for both performance and clarity:

https://forums.swift.org/t/how-effective-is-final-for-code-optimization/24934

It's easier to remove "final" if you should need to subclass one of the classes, than it is to add "final" to them all :-)

Contributor guide

Tech stack
typescriptswift
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Swift syntaxquicktype codebase structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the Swift code generation logic in quicktype's source code (likely in src/ or a language specific directory). Modify the class declarations to include the 'final' keyword. Review the forum link for context on performance benefits. Test by generating Swift code from a sample schema to verify the output.