glideapps/quicktype

Please generate "final" Swift classes

Open

#1,241 opened on May 30, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (968 forks)batch import
Swiftcustomizationgood first issue

Repository metrics

Stars
 (10,867 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

All of the generated Swift classes should be "final class" for both performance and clarity:

https://forums.swift.org/t/how-effective-is-final-for-code-optimization/24934

It's easier to remove "final" if you should need to subclass one of the classes, than it is to add "final" to them all :-)

Contributor guide

Research direction
Find the Swift code generation templates in the quicktype repository and add the 'final' keyword to all generated class declarations.
Tech stack
typescriptswift
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80